Fix TrendCheck creating Quality without a name #2584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A default Quality would be created when TrendCheck::beautify was trying to access a non-existent entry in mQualities map. When using operator[] with a missing key, the object is added using the default constructor, so Quality(10, "") was being created. This was causing crashes in QualityTask, which was relying on a non-empty Quality name to be there.
Collaborator
Author
|
@aferrero2707 FYI |
justonedev1
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A default Quality would be created when TrendCheck::beautify was trying to access a non-existent entry in mQualities map. When using operator[] with a missing key, the object is added using the default constructor, so Quality(10, "") was being created. This was causing crashes in QualityTask, which was relying on a non-empty Quality name to be there.